search

jetstack / kube-lego

DEPRECATED: Automatically request certificates for Kubernetes Ingress resources from Let's Encrypt
Apache License 2.0
2.16k stars 267 forks source link

Trailing slash on `lego.url` causes certificates not to be requested. #219

Closed EmlynC closed 6 years ago

EmlynC commented 7 years ago

I appreciate that a leaving a trailing slash on the lego.url may indicate that the user doesn't know how to format their URLs properly, but doing this:

...
data:
  lego.email: "emlyn@felix.com"
  lego.url: "https://acme-v01.api.letsencrypt.org/"

In configmap.yaml, will cause this error:

level=error msg="Error while processing certificate requests: Head : unsupported protocol scheme \"\"" context=kubelego

Could we make kube-lego a little more tolerant of a trailing slash 😄 ?

munnerz commented 7 years ago

Absolutely, that's an odd one! Thanks for reporting!

EmlynC commented 7 years ago

No worries @munnerz. I'm not that familiar with Go, but I can't imagine checking for a slash is a hard problem so I'll look to put a PR together.