Return ingress.class value for ingress.provider if not set

jetstack / kube-lego

DEPRECATED: Automatically request certificates for Kubernetes Ingress resources from Let's Encrypt

Apache License 2.0

2.16k stars 267 forks source link

Return ingress.class value for ingress.provider if not set #223

Closed munnerz closed 7 years ago

munnerz commented 7 years ago

This should solve a regression that causes the GCE ingress controller implementation to not work with manifests that don't explicitly set kubernetes.io/ingress.provider: gce. Without this change, these manifests would attempt to use the nginx provider.

This also solves a problem where the default supported ingress classes were not set correctly if not specified.

munnerz commented 7 years ago

This is a follow-up to the recently merged #202 - @simonswine could you take a look over.

/cc @jackhopner

jackhopner commented 7 years ago

Any reason to remove the option to set the default @munnerz ? We could have it check if the default was set otherwise return the ingress class?