search

jetstack / kube-lego

DEPRECATED: Automatically request certificates for Kubernetes Ingress resources from Let's Encrypt
Apache License 2.0
2.16k stars 267 forks source link

delete leftover from legoDefaultIngressProvider removal #239

Closed ElvinEfendi closed 6 years ago

ElvinEfendi commented 7 years ago

https://github.com/jetstack/kube-lego/commit/a4d76c22976301016cdbf1d16d7376520fa9896b deleted support for legoDefaultIngressProvider but did not clean up all the related code. The PR removes the leftover. pkg/mocks/mocks.go was modified using make codegen.

jackhopner commented 6 years ago

https://github.com/jetstack/kube-lego/pull/257 re-introduces the provider fyi.

munnerz commented 6 years ago

I've merged #257 now, so will close this. But thanks for noticing and making the PR!