search

jetstack / kube-lego

DEPRECATED: Automatically request certificates for Kubernetes Ingress resources from Let's Encrypt
Apache License 2.0
2.16k stars 267 forks source link

Reintroduce default ingress provider #257

Closed jackhopner closed 6 years ago

jackhopner commented 6 years ago

This implementation should be backwards compatible as it will default the provider to the same value as the class.

Relates to #233

munnerz commented 6 years ago

This LGTM. I think I removed code similar (although minus the defaulting to class) a while back. Thanks for working to get the default provider back in there without the backwards incompatibility!

munnerz commented 6 years ago

& thanks very much for the contribution too..!