search

jetstack / kube-lego

DEPRECATED: Automatically request certificates for Kubernetes Ingress resources from Let's Encrypt
Apache License 2.0
2.16k stars 267 forks source link

Broken links in README.md under "Ingress Controllers" #260

Closed supersam654 closed 6 years ago

supersam654 commented 6 years ago

It looks like both links under the "Ingress Controllers" heading are giving me 404s:

I (very) briefly poked around the ingress repo but didn't immediately see where those pages went. Normally, I'd recommend linking against a particular version of pages instead of against the master branch. However, I actually think it's better that the links broke and docs need to be updated because if those files don't exist anymore, Kubernetes probably made a breaking change.

supersam654 commented 6 years ago

It looks like the entire controllers/ directory was deleted/moved on Friday: https://github.com/kubernetes/ingress-nginx/pull/1494. The PR is rather large and there is no explanation as to why it was such a large change happened, but at least the links haven't been broken for too long.

EDIT: It looks like kubernetes/ingress just split into kubernetes/ingress-nginx and kubernetes/ingress-gce although I'm not still not entirely clear where the controllers/ directories went.