update only service with kube-lego-managed annotation

jetstack / kube-lego

DEPRECATED: Automatically request certificates for Kubernetes Ingress resources from Let's Encrypt

Apache License 2.0

2.16k stars 267 forks source link

update only service with kube-lego-managed annotation #267

Closed DocX closed 6 years ago

DocX commented 6 years ago

To workaround the issue with GCE here https://github.com/jetstack/kube-lego/issues/68 I want to setup manually service with selector and have kube-lego for each of my namespaces.

But kube-lego ignores the service annotation when it is updating the service. This adds check for kube-lego-managed=true annotation for updating existing service - similarly to the delete method already there.

DocX commented 6 years ago

Hi. Is there something wrong with the Pull Request? Can I somehow help to merge it?

simonswine commented 6 years ago

No nothing wrong, you could have pushed me a bit more. Sorry about the really late response...