jetstack / kube-lego

DEPRECATED: Automatically request certificates for Kubernetes Ingress resources from Let's Encrypt
Apache License 2.0
2.16k stars 267 forks source link

Make RSA key size configurable #269

Closed slintes closed 6 years ago

slintes commented 6 years ago

With this change the RSA key size is made configurable.

The given keysize is checked to be a number and to be >= 512... not sure if there should be more checks?

Fixes #111

slintes commented 6 years ago

just rebased on master

simonswine commented 6 years ago

Thanks for that, not too sure how non well known rsa key sizes (!= 1024, 2048, 4096) are handled by let's encrypt, but this shouldn't break anything