jetstack / kube-lego

DEPRECATED: Automatically request certificates for Kubernetes Ingress resources from Let's Encrypt
Apache License 2.0
2.16k stars 269 forks source link

Add spec selector to kube-lego/deployment #299

Closed chexxor closed 6 years ago

chexxor commented 6 years ago

Kubernetes 1.8 requires that spec.selector be specified. In prior versions, it would use a default value, but they are now disallowing that.

Also, the apiVersion should now be "apps/v1beta2", but can change in multiple places later.

simonswine commented 6 years ago

I have just tested to old apiVersion with 1.8 (both server and kubectl) and it seems to work fine without