Closed JoshVanL closed 4 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JoshVanL
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Should be good to have a look now /unassign /assign @simonswine /hold cancel /test pull-kube-oidc-proxy-e2e-v1-14 /test pull-kube-oidc-proxy-e2e-v1-13 /test pull-kube-oidc-proxy-e2e-v1-12 /test pull-kube-oidc-proxy-e2e-v1-11
/retest
@simonswine I have updated the docs to make it clear it will terminate the proxy on watch change and mentioned the HPA issue. I think the CLI flag is probably clear enough the exit behavior.
Comma-separated list of files to watch for changes. If a change is detected then send self a SIGHUP signal and exit gracefully.
I've updated the tests and will re-assign once they've passed.
@JoshVanL: The following tests failed, say /retest
to rerun them all:
Test name | Commit | Details | Rerun command |
---|---|---|---|
pull-kube-oidc-proxy-e2e-v1-16 | e0d6242ab4b037a2ac3b43f56f764ad254833ec1 | link | /test pull-kube-oidc-proxy-e2e-v1-16 |
pull-kube-oidc-proxy-e2e-v1-15 | e0d6242ab4b037a2ac3b43f56f764ad254833ec1 | link | /test pull-kube-oidc-proxy-e2e-v1-15 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
@JoshVanL: PR needs rebase.
This functionality should be checked whether this has been included, and if not, enabled using apiserver module
/close
@JoshVanL: Closed this PR.
What's the status on this PR? is this a feature that's not going to be included in future releases?
Thanks!
Hey @jescarri,
In theory, now that we have updated dependencies on k8s to 1.18, this should be included as default. I haven't tested this however, so if it isn't the case than I will do some investigating to make sure it's there.
In favor of #88
/hold /assign fixes #16 /milestone v0.2