jetstack / kube-oidc-proxy

Reverse proxy to authenticate to managed Kubernetes API servers via OIDC.
https://jetstack.io
Apache License 2.0
477 stars 91 forks source link

Makes readiness probe rely on proxy initialization on issuer #115

Closed JoshVanL closed 4 years ago

JoshVanL commented 4 years ago

Sets proxy readiness probe to be based on the initialization of it's discovery of the OIDC issuer.

Improves readiness probe to be based on whether the proxy has successfully made a discovery on the OIDC issuer

/assign /milestone v0.2 fixes #92

jetstack-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jetstack/kube-oidc-proxy/blob/master/OWNERS)~~ [JoshVanL] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
JoshVanL commented 4 years ago

/test pull-kube-oidc-proxy-e2e-v1-11 /test pull-kube-oidc-proxy-e2e-v1-12 /test pull-kube-oidc-proxy-e2e-v1-13 /test pull-kube-oidc-proxy-e2e-v1-14

JoshVanL commented 4 years ago

/unassign /assign @simonswine

JoshVanL commented 4 years ago

/unassign /assign @simonswine

simonswine commented 4 years ago

/lgtm