jetstack / kube-oidc-proxy

Reverse proxy to authenticate to managed Kubernetes API servers via OIDC.
https://jetstack.io
Apache License 2.0
477 stars 91 forks source link

Cleans up command options package #129

Closed JoshVanL closed 4 years ago

JoshVanL commented 4 years ago

Managing options for the kube-oidc-proxy has become quite unwieldy which makes it difficult to work on and add new flags. This PR updates the options package to return a single options struct which provides a much better interface for the consuming package. This PR also moves more into the options package where it makes sense which cleans things up a bit more.

/assign @simonswine

jetstack-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jetstack/kube-oidc-proxy/blob/master/OWNERS)~~ [JoshVanL] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
simonswine commented 4 years ago

Needs rebase

/assign @JoshVanL /unassign

JoshVanL commented 4 years ago

/unassign /assign @simonswine

JoshVanL commented 4 years ago

Think I addressed your comments /unassign /assign @simonswine

JoshVanL commented 4 years ago

/retest

simonswine commented 4 years ago

Nice on, thanks

/lgtm