Closed JoshVanL closed 4 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JoshVanL
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs rebase
/assign @JoshVanL /unassign
/unassign /assign @simonswine
Think I addressed your comments /unassign /assign @simonswine
/retest
Nice on, thanks
/lgtm
Managing options for the kube-oidc-proxy has become quite unwieldy which makes it difficult to work on and add new flags. This PR updates the options package to return a single options struct which provides a much better interface for the consuming package. This PR also moves more into the options package where it makes sense which cleans things up a bit more.
/assign @simonswine