Set client IP as x-forwarded value is available.

jetstack / kube-oidc-proxy

Reverse proxy to authenticate to managed Kubernetes API servers via OIDC.

https://jetstack.io

Apache License 2.0

477 stars 91 forks source link

Set client IP as x-forwarded value is available. #134

Closed JoshVanL closed 4 years ago

JoshVanL commented 4 years ago

If the x-forwarded header is present then this will be used as the client IP.

/assign @simonswine rebased ontop of #133 /hold fixes #132

jetstack-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jetstack/kube-oidc-proxy/blob/master/OWNERS)~~ [JoshVanL] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

munnerz commented 4 years ago

/cc

JoshVanL commented 4 years ago

/unassign @simonswine /assign @munnerz

munnerz commented 4 years ago

/lgtm /hold

munnerz commented 4 years ago

/lgtm

munnerz commented 4 years ago

Unhold when you see fit!

JoshVanL commented 4 years ago

@munnerz Probably needs a rebase......

JoshVanL commented 4 years ago

@munnerz Rebased

I also changed things around so that the update remote addr gets stored in context.

Context also now returns the new request itself which is a bit cleaner during calls

JoshVanL commented 4 years ago

/hold cancel

munnerz commented 4 years ago

/lgtm