Closed mkinsley closed 4 years ago
Hi @mkinsley,
It is annoying you are running into this. As you can see from the golang docs, running with a 0 value means no periodic flushing which is the current behavior.
I would like to see this changed to some sane value that can be configured. I am nervous at having a negative value as the default, perhaps 200ms would be better?
I would like more advise here on what the implications of having immediate vs periodic flushing means. In the mean time I'll put a PR together to put things in place before we agree on what the default should be.
/cc @simonswine
/assign @mkinsley
Whoops!
/unassign @mkinsley /assign
I have opened up this PR to fix this https://github.com/jetstack/kube-oidc-proxy/pull/137
Expect
Non-full buffers should flush in a reasonable amount of time
Observed
Symptoms
Fix I set the proxy to flush immediately and the issue resolves. I'm happy to submit a PR if you would like. We could flush immediately, pick a sane value, or make it configurable.