Closed JoshVanL closed 4 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JoshVanL
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest
/cc
/unassign @simonswine /assign @munnerz
This PR needs a rebase, and will probably need more once #133 merges - this lgtm though :)
/lgtm /hold
/retry
/lgtm
I'll leave /unhold
ing to you @JoshVanL!
/unassign /assign @JoshVanL
/hold cancel
Currently, the proxy holds all of the business logic in the RoundTrip func. This has become quite unwieldy, and difficult to test. This PR moves each stage of the proxy into http.Handler which makes things a bit more cleaner and idiomatic. This is also a prerequisite for the audit work.
This PR makes use of context in the request to hold state of user information, impersonate etc.
This PR is branched out of #133 and should be merged first.
/assign @simonswine /hold