Closed JoshVanL closed 4 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JoshVanL
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/test pull-kube-oidc-proxy-e2e-v1-17
/test pull-kube-oidc-proxy-e2e-v1-16 /test pull-kube-oidc-proxy-e2e-v1-15 /test pull-kube-oidc-proxy-e2e-v1-14 /test pull-kube-oidc-proxy-e2e-v1-13 /test pull-kube-oidc-proxy-e2e-v1-12 /test pull-kube-oidc-proxy-e2e-v1-11
I would be interested in the use case here.
I think users might also want to have different proxy settings for API server proxy vs. other request like the one to the OIDC endpoints.
I don't know if you want to say more about the use case.
I think if there is a request for different proxy settings we can augment this later with e.g. extra env variables used by a custom function without breaking anything for anyone that uses this support.
/lgtm
Signed-off-by: JoshVanL vleeuwenjoshua@gmail.com
/assign @munnerz fixes #153