search

jetstack / kube-oidc-proxy

Reverse proxy to authenticate to managed Kubernetes API servers via OIDC.
https://jetstack.io
Apache License 2.0
477 stars 91 forks source link

Enable HTTP_PROXY and HTTPS_PROXY environment variables #154

Closed JoshVanL closed 4 years ago

JoshVanL commented 4 years ago

Signed-off-by: JoshVanL vleeuwenjoshua@gmail.com

/assign @munnerz fixes #153 

Enable use of HTTP_PROXY and HTTPS_PROXY environment variables for the proxy
jetstack-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jetstack/kube-oidc-proxy/blob/master/OWNERS)~~ [JoshVanL] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
JoshVanL commented 4 years ago

/test pull-kube-oidc-proxy-e2e-v1-17

JoshVanL commented 4 years ago

/test pull-kube-oidc-proxy-e2e-v1-16 /test pull-kube-oidc-proxy-e2e-v1-15 /test pull-kube-oidc-proxy-e2e-v1-14 /test pull-kube-oidc-proxy-e2e-v1-13 /test pull-kube-oidc-proxy-e2e-v1-12 /test pull-kube-oidc-proxy-e2e-v1-11

simonswine commented 4 years ago

I would be interested in the use case here.

I think users might also want to have different proxy settings for API server proxy vs. other request like the one to the OIDC endpoints.

james-w commented 4 years ago

I don't know if you want to say more about the use case.

I think if there is a request for different proxy settings we can augment this later with e.g. extra env variables used by a custom function without breaking anything for anyone that uses this support.

/lgtm