search

jetstack / kube-oidc-proxy

Reverse proxy to authenticate to managed Kubernetes API servers via OIDC.
https://jetstack.io
Apache License 2.0
477 stars 91 forks source link

Add metrics #158

Open JoshVanL opened 4 years ago

JoshVanL commented 4 years ago

This PR metrics adds a number of metrics to the proxy.

The PR should be split up fairly well per commit.

It would be good to have a bit of insight into whether these metrics look sane... It is tricky not to make the number of time series explode here.

/assign @munnerz /assign @simonswine fixes #156

jetstack-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jetstack/kube-oidc-proxy/blob/master/OWNERS)~~ [JoshVanL] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
JoshVanL commented 4 years ago

Thanks for the review @james-w :) I've made the suggested changes or responded to you comments, and should be ready for another look /unassign /assign @james-w

SimplySeth commented 4 years ago

Pardon my ignorance, is this complete ? How do I get access to the metrics if it is? Thanks.