Open JoshVanL opened 4 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JoshVanL
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Thanks for the review @james-w :) I've made the suggested changes or responded to you comments, and should be ready for another look /unassign /assign @james-w
Pardon my ignorance, is this complete ? How do I get access to the metrics if it is? Thanks.
This PR metrics adds a number of metrics to the proxy.
The PR should be split up fairly well per commit.
It would be good to have a bit of insight into whether these metrics look sane... It is tricky not to make the number of time series explode here.
/assign @munnerz /assign @simonswine fixes #156