search

jetstack / kube-oidc-proxy

Reverse proxy to authenticate to managed Kubernetes API servers via OIDC.
https://jetstack.io
Apache License 2.0
476 stars 92 forks source link

Run as Non Root #168

Closed robbo10 closed 3 years ago

robbo10 commented 4 years ago

Signed-off-by: Kieran Robinson Kieran.Robinson7@gmail.com

jetstack-bot commented 4 years ago

Hi @robbo10. Thanks for your PR.

I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
robbo10 commented 4 years ago

/assign @alljames

robbo10 commented 4 years ago

/check-dco

robbo10 commented 4 years ago

Signed-off-by: Kieran Robinson Kieran.Robinson7@gmail.com

JoshVanL commented 3 years ago

/lgtm /approve /ok-to-test

jetstack-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL, robbo10

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jetstack/kube-oidc-proxy/blob/master/OWNERS)~~ [JoshVanL] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
JoshVanL commented 3 years ago

/retest

robbo10 commented 3 years ago

/retest

jetstack-bot commented 3 years ago

@robbo10: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kube-oidc-proxy-e2e-v1-18 5d3471bf2a9e0c3ef656a0fd708a75e78861f93b link /test pull-kube-oidc-proxy-e2e-v1-18

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
robbo10 commented 3 years ago

@JoshVanL - I'm unsure why that last test is failing 😕