search

jetstack / kube-oidc-proxy

Reverse proxy to authenticate to managed Kubernetes API servers via OIDC.
https://jetstack.io
Apache License 2.0
478 stars 92 forks source link

fix_secret_config #171

Closed allanhung closed 3 years ago

allanhung commented 3 years ago

fix error when do the helm install.

YAML parse error on kube-oidc-proxy/templates/secret_config.yaml: error converting YAML to JSON: yaml: line 6: did not find expected key

Signed-off-by: Allan Hung hung.allan@gmail.com

jetstack-bot commented 3 years ago

Hi @allanhung. Thanks for your PR.

I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
allanhung commented 3 years ago

/assign @joshvanl

sorensonpragmatics commented 3 years ago

I just ended up doing this myself. Then thought to myself I should make a PR! but here it is already. This change is exactly the same as what I did. I know I am not a maintainer but this should be a fast approve.

JoshVanL commented 3 years ago

Thanks for this!

/approve /lgtm /ok-to-test

jetstack-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: allanhung, JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jetstack/kube-oidc-proxy/blob/master/OWNERS)~~ [JoshVanL] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment