search

jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

Create a headless service so that other nodes can lookup the seed provider #128

Closed wallrj closed 6 years ago

wallrj commented 6 years ago

Fixes: #127

Release note:

NONE
wallrj commented 6 years ago

/test all

wallrj commented 6 years ago

/test all

munnerz commented 6 years ago

/retest

wallrj commented 6 years ago

/retest

On Nov 14, 2017 17:50, "jetstack-bot" notifications@github.com wrote:

@wallrj https://github.com/wallrj: The following tests failed, say /retest to rerun them all: Test name Commit Details Rerun command navigator-e2e-v1-8 4568cce https://github.com/jetstack/navigator/commit/4568ccec361a36b178d9257e904b39247241e976 link https://jetstack-build-infra.appspot.com/build/jetstack-logs/pr-logs/pull/jetstack_navigator/128/navigator-e2e-v1-8/63/ /test e2e v1.8 navigator-e2e-v1-7 4568cce https://github.com/jetstack/navigator/commit/4568ccec361a36b178d9257e904b39247241e976 link https://jetstack-build-infra.appspot.com/build/jetstack-logs/pr-logs/pull/jetstack_navigator/128/navigator-e2e-v1-7/51/ /test e2e v1.7

Full PR test history https://jetstack-build-infra.appspot.com/pr/jetstack_navigator/128. Your PR dashboard https://jetstack-build-infra.appspot.com/pr/wallrj. Please help us cut down on flakes by linking to https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests an open issue https://github.com/jetstack/navigator/issues?q=is:issue+is:open when you hit one in your PR.

Instructions for interacting with me using PR comments are available here https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue: repository. I understand the commands that are listed here https://github.com/kubernetes/test-infra/blob/master/commands.md.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jetstack/navigator/pull/128#issuecomment-344340913, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7wFQfaobTdOkRlNu-ZQZROC3DeJF75ks5s2dLLgaJpZM4QdTD- .

wallrj commented 6 years ago

/test all

munnerz commented 6 years ago

/test all

wallrj commented 6 years ago

/test e2e

wallrj commented 6 years ago

Logs show:

I1116 12:09:56.387] INFO  12:09:48 Starting Messaging Service on /172.17.0.8:7000 (eth0)
I1116 12:09:56.387] WARN  12:09:48 No host ID found, created 471089dd-269d-498f-a96d-1c8cb577b79c (Note: This should happen exactly once per node).
I1116 12:09:56.387] INFO  12:09:49 Handshaking version with cass-cassandra-1510834028-24677-cassandra-ringnodes-0.cass-cassandra-1510834028-24677-cassandra-seedprovider.test-cassandracluster-1510834028-24677.svc.cluster.local/172.17.0.7
I1116 12:09:56.387] WARN  12:09:54 Seed gossip version is -2147483648; will not connect with that version
I1116 12:09:56.387] INFO  12:09:54 Cannot handshake version with cass-cassandra-1510834028-24677-cassandra-ringnodes-0.cass-cassandra-1510834028-24677-cassandra-seedprovider.test-cassandracluster-1510834028-24677.svc.cluster.local/172.17.0.7
I1116 12:09:56.388] INFO  12:09:54 Handshaking version with cass-cassandra-1510834028-24677-cassandra-ringnodes-0.cass-cassandra-1510834028-24677-cassandra-seedprovider.test-cassandracluster-1510834028-24677.svc.cluster.local/172.17.0.7

Perhaps I just need to give the second node longer to connect to the first. This test passes on my GKE cluster.

wallrj commented 6 years ago

/test e2e

munnerz commented 6 years ago

Could you squash this into 1 commit before merge? 😄

munnerz commented 6 years ago

(then all good! I don't want to say the magic phrase for fear this will auto merge... 🙄 )

wallrj commented 6 years ago

Could you squash this into 1 commit before merge?

@munnerz Done. Thanks for the review.

munnerz commented 6 years ago

/lgtm /approve

jetstack-ci-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - ~~[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)~~ [munnerz] You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
munnerz commented 6 years ago

/test all

jetstack-ci-bot commented 6 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

jetstack-ci-bot commented 6 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

jetstack-ci-bot commented 6 years ago

Automatic merge from submit-queue.