search

jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

Add genericpilot Sync unit tests #148

Closed munnerz closed 6 years ago

munnerz commented 6 years ago

What this PR does / why we need it:

Adds unit tests for the genericpilot Sync method

Release note:

NONE
munnerz commented 6 years ago

/test e2e

jetstack-ci-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: We suggest the following additional approver: munnerz

Assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - **[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)** You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
munnerz commented 6 years ago

This needs a rebase once #149 has merged

munnerz commented 6 years ago

/test e2e

munnerz commented 6 years ago

@wallrj I've refactored this a bit and added comments throughout. Now ready for review!

/test e2e

jetstack-ci-bot commented 6 years ago

@munnerz PR needs rebase