jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

WIP: Shutdown pilot when there isn't a matching resource or sub process #174

Closed wallrj closed 6 years ago

wallrj commented 6 years ago

Fixes: #171

Release note:

NONE
jetstack-ci-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: We suggest the following additional approver: munnerz

Assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - **[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)** You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
wallrj commented 6 years ago

/test e2e

wallrj commented 6 years ago

/test e2e

jetstack-bot commented 6 years ago

@wallrj: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
navigator-e2e-v1-8 568281b6cd06054a48befc912454e515aba6b8a5 link /test e2e v1.8
navigator-e2e-v1-7 568281b6cd06054a48befc912454e515aba6b8a5 link /test e2e v1.7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).
jetstack-ci-bot commented 6 years ago

@wallrj PR needs rebase

munnerz commented 6 years ago

Going to close this as it's been addressed as part of #183

/close