jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

Dump namespace info/logs on test failure to artifacts directory #175

Closed munnerz closed 6 years ago

munnerz commented 6 years ago

/cc @wallrj

NONE
munnerz commented 6 years ago

/test e2e

munnerz commented 6 years ago

/test e2e

munnerz commented 6 years ago

/test e2e

wallrj commented 6 years ago

Ah, sorry, my fault for suggesting adding the ElasticSearchCluster to the list of resources to be deleted. That won't work with the initial namespace deletion because navigator api server isn't running yet. Maybe it isn't necessary.

munnerz commented 6 years ago

/test e2e

jetstack-ci-bot commented 6 years ago

@munnerz PR needs rebase

munnerz commented 6 years ago

/test e2e

munnerz commented 6 years ago

/test e2e

munnerz commented 6 years ago

/test e2e

munnerz commented 6 years ago

/test e2e

munnerz commented 6 years ago

Trying to pick up flakes

/retest

jetstack-ci-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - ~~[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)~~ [wallrj] You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
jetstack-ci-bot commented 6 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

jetstack-ci-bot commented 6 years ago

Automatic merge from submit-queue.

wallrj commented 6 years ago

Ah. Sorry @munnerz

I didn't mean for it to be auto merged. And it turns out that there's a bug when a test fails.

+ fail_test 'Elasticsearch pilot did not update the document count'
+ FAILURE_COUNT=1
+ echo 'TEST FAILURE: Elasticsearch pilot did not update the document count'
+ '[' 1 -gt 0 ']'
+ fail_and_exit test-elasticsearchcluster-1513251127-21582
+ local namespace=test-elasticsearchcluster-1513251127-21582
+ test_logged_errors test-elasticsearchcluster-1513251127-21582
/home/richard/go/src/github.com/jetstack/navigator/hack/libe2e.sh: line 134: test_logged_errors: command not found
wallrj commented 6 years ago

I've done a quick fix for that in https://github.com/jetstack/navigator/pull/176