search

jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

Parameterise ES cluster yaml in tests #179

Closed wallrj closed 6 years ago

wallrj commented 6 years ago

Allows me to override the ES pilot image parameters when I'm running tests manually on GKE.

Using envsubst as a much lighter weight alternative to using helm chart. Discovered via: https://github.com/kubernetes/kubernetes/issues/23896#issuecomment-303480182

Stacked on #177

Release note:

NONE
wallrj commented 6 years ago

/test e2e

wallrj commented 6 years ago

/test e2e

wallrj commented 6 years ago

/test e2e

munnerz commented 6 years ago

/lgtm /approve

jetstack-ci-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - ~~[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)~~ [munnerz] You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
jetstack-ci-bot commented 6 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

munnerz commented 6 years ago

/retest

jetstack-ci-bot commented 6 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

jetstack-ci-bot commented 6 years ago

Automatic merge from submit-queue.