search

jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

Use label selector when listing pods in es controller #187

Closed munnerz closed 6 years ago

munnerz commented 6 years ago

What this PR does / why we need it:

Use a label selector in the Elasticsearch navigator-controller implementations when listing pods to create Pilots for.

This also simplifies the Pilot creation code and decouples it from node pools.

Release note:

NONE
munnerz commented 6 years ago

/test e2e

munnerz commented 6 years ago

/test all

munnerz commented 6 years ago

Thanks for taking a look @wallrj. I've updated to reintroduce the ownership check as it is still necessary. Regarding two ownerReferences - it would be nice, but also quite complex to do via a StatefulSet pod template (and perhaps not possible?). For now I think it's easiest to keep the behaviour the same.

munnerz commented 6 years ago

/approve

jetstack-ci-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - ~~[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)~~ [munnerz] You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
jetstack-ci-bot commented 6 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

munnerz commented 6 years ago

Test flake caused by #106. I've opened #188 which should resolve it.

munnerz commented 6 years ago

/test verify

jetstack-ci-bot commented 6 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

jetstack-ci-bot commented 6 years ago

Automatic merge from submit-queue.