search

jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

elasticsearch: Replace 'config' field with 'minimumMasters' #196

Closed munnerz closed 6 years ago

munnerz commented 6 years ago

What this PR does / why we need it:

This PR alters the API surface for ElasticsearchCluster. It replaces the config field on node pools with a cluster wide minimum masters field.

The official Elastic recommendation is to modify the majority of cluster settings through the cluster API, and without a specific request to have a method to specify static config, I think we're best to remove this field for now.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Related to #194

Release note:

Remove 'config' field from node pools and replace with cluster-wide 'minimumMasters' field
jetstack-ci-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: We suggest the following additional approver: munnerz

Assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - **[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)** You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
munnerz commented 6 years ago

/test e2e v1.7

jetstack-ci-bot commented 6 years ago

@munnerz PR needs rebase

jetstack-ci-bot commented 6 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

munnerz commented 6 years ago

/hold cancel

jetstack-ci-bot commented 6 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

jetstack-ci-bot commented 6 years ago

Automatic merge from submit-queue.