jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

Use pilotName as selector when getting document count #197

Closed munnerz closed 6 years ago

munnerz commented 6 years ago

What this PR does / why we need it:

Fixes an issue when reporting the document count where another nodes document count could be returned from the Elasticsearch API, causing controllers to flap and creating extra load on the navigator-apiserver (up to ~10-15RPS created with stats flip-flopping).

Release note:

Fix bugs in Pilot document count reporting
jetstack-ci-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: We suggest the following additional approver: munnerz

Assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - **[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)** You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
munnerz commented 6 years ago

/test e2e

jetstack-ci-bot commented 6 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

jetstack-ci-bot commented 6 years ago

Automatic merge from submit-queue.