search

jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

Add defaults for ElasticsearchCluster pilot image #206

Closed munnerz closed 6 years ago

munnerz commented 6 years ago

What this PR does / why we need it:

Adds a defaulting function for the Elasticsearch pilot image spec. This makes pilot an optional field.

Special notes for your reviewer:

We need to think about how this will update over time. Currently, it's up to the end users of the cluster to ensure the pilot version used is compatible with/within a reasonable range of navigator.

navigator-controller needs to support periodically updating the pilot image specified on Cassandra/ElasticsearchCluster resources, thus triggering the regular cluster upgrade procedure. i'm going to open a separate issue to track this as this is a larger design decision.

Release note:

Make 'spec.pilot' an optional field on ElasticsearchClusters
jetstack-ci-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: We suggest the following additional approver: munnerz

Assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - **[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)** You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
munnerz commented 6 years ago

Yep we should use omitempty - could call.

General Pilot upgrade strategy is discussed in #203 - this may be tricky, and might result in us moving the field altogether. Perhaps we should 'fully manage' this (as in, don't have a field on the resource at all and instead 'just do it')..... 🙄

jetstack-ci-bot commented 6 years ago

@munnerz PR needs rebase

munnerz commented 6 years ago

Closing this for now. We need to think about how we handle versioning Pilot, and how we roll out upgrades.

/close

jetstack-bot commented 6 years ago

@munnerz: The close prow plugin is deprecated, please migrate to the lifecycle plugin before April 2018

In response to [this](https://github.com/jetstack/navigator/pull/206#issuecomment-358375736): >Closing this for now. We need to think about how we handle versioning Pilot, and how we roll out upgrades. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.