jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

WIP: Add custom column printing to openapi spec #208

Closed munnerz closed 4 years ago

munnerz commented 6 years ago

What this PR does / why we need it:

This PR adds custom column printing for ElasticsearchCluster resources. I've not had a chance to test it yet in a live environment.

Special notes for your reviewer:

This builds on #204

Release note:

Print custom columns in output of kubectl get elasticsearchclusters
jetstack-ci-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: We suggest the following additional approver: munnerz

Assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - **[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)** You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
munnerz commented 6 years ago

/test e2e v1.8

munnerz commented 6 years ago

/retest

jetstack-bot commented 6 years ago

@munnerz: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
navigator-quick-verify bdef8f1d2fddc7c6990f0fa61f93f10d35958692 link /test verify
navigator-e2e-v1-9 bdef8f1d2fddc7c6990f0fa61f93f10d35958692 link /test e2e v1.9
navigator-e2e-v1-7 bdef8f1d2fddc7c6990f0fa61f93f10d35958692 link /test e2e v1.7
navigator-e2e-v1-8 bdef8f1d2fddc7c6990f0fa61f93f10d35958692 link /test e2e v1.8

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jetstack-ci-bot commented 6 years ago

@munnerz PR needs rebase