search

jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

Add Elasticsearch e2e test for pod running #210

Closed munnerz closed 6 years ago

munnerz commented 6 years ago

What this PR does / why we need it:

We currently see the odd failure that is caused simply by not allowing pods enough time to start.

This PR adds an additional e2e test that runs before the doc count/health test, that will ensure that the pod has entered the 'Running' phase before starting to check for document count.

From looking at logs, it seems the pod takes 2 minutes alone to get to a Running state (i.e. pilot-elasticsearch has been started). This allows only 3 minutes for the ES cluster to start, and for pilot to update the API with required info.

With this change, we buy an extra 2 minutes without any time penalty to builds that will go on to succeed.

Release note:

NONE
jetstack-ci-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: We suggest the following additional approver: munnerz

Assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - **[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)** You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
munnerz commented 6 years ago

/retest

jetstack-ci-bot commented 6 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

jetstack-ci-bot commented 6 years ago

Automatic merge from submit-queue.