jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

Use goimports for lint checking #213

Closed munnerz closed 6 years ago

munnerz commented 6 years ago

This switches us to use goimports for linting of files. It performs the same role as gofmt, plus also checks import paths and makes sure they are grouped according to guidelines.

For reference, the 'correct' format:

import (
    // stdlib packages
    "fmt"
    "os/exec"

    // external packages
    "github.com/golang/glog"
    "k8s.io/apimachinery/pkg/apis/meta/v1"

    // packages belonging to our repo
    "github.com/jetstack/navigator/pkg/apis/v1alpha1"
)

Release note:

NONE
jetstack-ci-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - ~~[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)~~ [wallrj] You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
jetstack-ci-bot commented 6 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

jetstack-ci-bot commented 6 years ago

Automatic merge from submit-queue.