search

jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

Add shared NavigatorClusterConfig API struct and enable Cassandra validation #214

Closed munnerz closed 6 years ago

munnerz commented 6 years ago

What this PR does / why we need it:

Creates a NavigatorClusterConfig structure to be embedded in each type of supported navigator database. This should be inlined into the types spec.

This allows us to define some fields that are shared between all databases/systems that Navigator supports. For now, each controller should implement these in a similar way, or explicitly specify it does not have a support for a field through validation.

Release note:

Rename sysctl to sysctls. Move FSGroup field to spec.securityContext.runAsUser
jetstack-ci-bot commented 6 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

jetstack-ci-bot commented 6 years ago

/lgtm cancel //PR changed after LGTM, removing LGTM. @munnerz @wallrj

wallrj commented 6 years ago

/lgtm

jetstack-ci-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - ~~[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)~~ [wallrj] You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
jetstack-ci-bot commented 6 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

jetstack-ci-bot commented 6 years ago

Automatic merge from submit-queue.