Refactor Elasticsearch node pool controller into Actions structures

jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes

Apache License 2.0

271 stars 31 forks source link

Refactor Elasticsearch node pool controller into Actions structures #241

Closed munnerz closed 6 years ago

munnerz commented 6 years ago

What this PR does / why we need it:

This gives us a generic way to implement 'Actions' against a given 'State' structure, and additionally introduces a unit testing framework that can be reused between controllers for testing Actions.

See #228

fixes #215

Special notes for your reviewer:

Stacks on #240, #239

Release note:

Updated Elasticsearch controller that carefully manages upgrade rollouts

munnerz commented 6 years ago

/hold

jetstack-ci-bot commented 6 years ago

@munnerz PR needs rebase

munnerz commented 6 years ago

@wallrj PR ready for another review. I've addressed changes in later commits to make it easier to see my newest changes.

/hold cancel

jetstack-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - ~~[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)~~ [wallrj] You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment

jetstack-ci-bot commented 6 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

jetstack-ci-bot commented 6 years ago

Automatic merge from submit-queue.