Closed munnerz closed 4 years ago
/test e2e
/hold
@munnerz PR needs rebase
/hold cancel
@munnerz PR needs rebase
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: munnerz
Assign the PR to them by writing /assign @munnerz
in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest
I got the following error when I tried running the tests on my dind cluster:
You've got --context=$HOSTNAME
on your e2e test command, hence the error about missing context 😄
You've got --context=$HOSTNAME on your e2e test command, hence the error about missing context
Sure, but I think I should be able to run make e2e-tests
on my local cluster and it should just use the default context.
@munnerz: PR needs rebase.
What this PR does / why we need it:
Adds a ginkgo based e2e testing framework, and updates the Elasticsearch e2e tests to be written with it.
fixes #32, fixes #156
Special notes for your reviewer:
Stacked on #241, #240 and #239
Release note: