jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

Add ginkgo e2e testing framework #242

Closed munnerz closed 4 years ago

munnerz commented 6 years ago

What this PR does / why we need it:

Adds a ginkgo based e2e testing framework, and updates the Elasticsearch e2e tests to be written with it.

fixes #32, fixes #156

Special notes for your reviewer:

Stacked on #241, #240 and #239

Release note:

NONE
munnerz commented 6 years ago

/test e2e

munnerz commented 6 years ago

/hold

jetstack-ci-bot commented 6 years ago

@munnerz PR needs rebase

munnerz commented 6 years ago

/hold cancel

jetstack-ci-bot commented 6 years ago

@munnerz PR needs rebase

jetstack-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: munnerz

Assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
munnerz commented 6 years ago

/retest

munnerz commented 6 years ago

I got the following error when I tried running the tests on my dind cluster:

You've got --context=$HOSTNAME on your e2e test command, hence the error about missing context 😄

wallrj commented 6 years ago

You've got --context=$HOSTNAME on your e2e test command, hence the error about missing context

Sure, but I think I should be able to run make e2e-tests on my local cluster and it should just use the default context.

jetstack-bot commented 6 years ago

@munnerz: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.