Add a CassandraCluster.Version field

[wallrj]

• CassandraCluster now has a Version field which must be a valid semver.
• CassandraCluster.Image is now optional
• and if ommitted will default to the image from docker.io/cassandra matching the supplied semver version.
• If Image is supplied, its repository and tag must be supplied, but pullPolicy is optional.
• Created shared test cases for NavigatorClusterConfig validation.
• In the Cassandra helm chart, I've removed the ability to override the cassandra image tag and repository for now, because its not needed in any of the tests.

Fixes: #234

Release note:

NONE

[jetstack-ci-bot]

@wallrj PR needs rebase

[munnerz]

Moved Version and Image into the NavigatorClusterConfig which is shared between Elasticsearch and Casandra clusters.

I'm not sure if we want to do this. I'd imagine some instances where a DB may not follow such simple schematics, although I'm not certain yet. For the time being, would it be harmful to keep these fields defined on each Navigator resource?

Either way it'll be a non-breaking change to our API surface to change it (as the navigator generic config is inlined into the spec stanza)

[wallrj]

I'm not sure if we want to do this. I'd imagine some instances where a DB may not follow such simple schematics, although I'm not certain yet.

You've got a point. I went looking for databases with non-semver versions and found Oracle.

• https://docs.oracle.com/cd/B28359_01/server.111/b28310/dba004.htm#ADMIN11032

These do use semver:

• https://hub.docker.com/r/scylladb/scylla/tags/
• https://hub.docker.com/_/mariadb/
• https://hub.docker.com/_/mysql/
• https://hub.docker.com/_/postgres/

For the time being, would it be harmful to keep these fields defined on each Navigator resource?

Yeah, ok. I'll revert that change.

[jetstack-ci-bot]

@wallrj PR needs rebase

[wallrj]

/retest

[wallrj]

The E2E failure (above) was caused by failure in kubeadm provisioning

W0215 17:55:24.766] E0215 17:55:24.765859 409 start.go:264] Error starting cluster: kubeadm init error running command: sudo /usr/bin/kubeadm init --config /var/lib/kubeadm.yaml --skip-preflight-checks: Process exited with status 1

Can't tell what went wrong. Perhaps we need to increase the kubeadm logging level somehow.

[jetstack-ci-bot]

@wallrj PR needs rebase

[wallrj]

Rebased.

[wallrj]

The 1.9 E2E test failure was caused by a kubeadm error:

• https://jetstack-build-infra.appspot.com/build/jetstack-logs/pr-logs/pull/jetstack_navigator/244/navigator-e2e-v1-9/403/

W0227 14:23:02.300] E0227 14:23:02.300130     407 start.go:264] Error starting cluster:  kubeadm init error running command: sudo /usr/bin/kubeadm init --config /var/lib/kubeadm.yaml --skip-preflight-checks: Process exited with status 1
W0227 14:23:02.303] Saving minikube logs...
W0227 14:23:02.303] Run: 'minikube --bootstrapper=kubeadm --profile faaa368d-1bc0-11e8-a45e-0a580a1c8f0b logs'
I0227 14:23:02.404] ================================================================================
I0227 14:23:02.404] An error has occurred. Would you like to opt in to sending anonymized crash
I0227 14:23:02.404] information to minikube to help prevent future errors?
I0227 14:23:02.404] To opt out of these messages, run the command:
I0227 14:23:02.404]     minikube config set WantReportErrorPrompt false
I0227 14:23:02.404] ================================================================================

/retest

[wallrj]

E2E tests failed again, this time because of a failure to download the Kubernetes seed provider for cassandra pilot image:

• https://jetstack-build-infra.appspot.com/build/jetstack-logs/pr-logs/pull/jetstack_navigator/244/navigator-e2e-v1-9/414/

I0227 17:25:11.874] Removing intermediate container ea49e3d0d6f6
I0227 17:25:11.874] Step 3/7 : RUN chmod a+r /jolokia.jar && touch /jolokia.jar
I0227 17:25:11.964]  ---> Running in dd13b0658cbc
I0227 17:25:12.811]  ---> 1252f93b1a05
I0227 17:25:12.859] Removing intermediate container dd13b0658cbc
I0227 17:25:12.860] Step 4/7 : ADD https://github.com/kubernetes/examples/raw/master/cassandra/image/files/kubernetes-cassandra.jar /kubernetes-cassandra.jar
W0227 17:25:23.235] ADD failed: Got HTTP status code >= 400: 504 Gateway Time-out
W0227 17:25:23.237] make: *** [docker_build_pilot-cassandra] Error 1

/retest

[jetstack-ci-bot]

@wallrj PR needs rebase

[wallrj]

Rebased

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kragniz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - ~~[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)~~ [kragniz] You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment

[jetstack-ci-bot]

/test all [submit-queue is verifying that this PR is safe to merge]

[jetstack-ci-bot]

Automatic merge from submit-queue.