jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

Add kubernetes-cassandra seed provider #245

Closed kragniz closed 6 years ago

kragniz commented 6 years ago

What this PR does / why we need it: This adds and configures the seed provider from kubernetes/examples.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #223

Special notes for your reviewer:

Release note:

Add kubernetes seed provider
kragniz commented 6 years ago

Based on this comment, support for configuring the seed provider via enviroment variables isn't going to happen in library/cassandra. Currently I configure this by doing a find+replace on the config file in the pilot, but this feels pretty hacky. Where should similar config tweaks go?

jetstack-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - ~~[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)~~ [wallrj] You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
jetstack-ci-bot commented 6 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

jetstack-ci-bot commented 6 years ago

Automatic merge from submit-queue.