search

jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

Add CreateNodePool and ScaleOut actions for Cassandra #256

Closed wallrj closed 6 years ago

wallrj commented 6 years ago

These become the only changes supported by the Cassandra controller until ScaleIn and CassandraUpgrade actions are implemented in followup branches.

Fixes: #253

Release note:

NONE
jetstack-ci-bot commented 6 years ago

@wallrj PR needs rebase

jetstack-ci-bot commented 6 years ago

@wallrj PR needs rebase

wallrj commented 6 years ago

rebased

wallrj commented 6 years ago

/retest

jetstack-ci-bot commented 6 years ago

@wallrj PR needs rebase

wallrj commented 6 years ago

Noticed a weird E2E test error:

W0324 14:27:19.643] + kubectl --namespace=test-cassandra-1521900884-833 exec cass-test-ringnodes-0 -- bash -c 'kill -SIGSTOP -- $(ps -u cassandra -o pid=) && ps faux'
I0324 14:27:20.340] rpc error: code = 2 desc = oci runtime error: exec failed: container_linux.go:262: starting container process caused "process_linux.go:86: adding pid 17816 to cgroups caused \"failed to write 17816 to cgroup.procs: write /sys/fs/cgroup/cpu,cpuacct/kubepods/poddc1388be-2f6e-11e8-8210-5254001464f2/f148ee0881cb5644368505fc324414543c01c6046f6e9850c52cc4f48ce72801/cgroup.procs: invalid argument\""

Maybe caused by https://github.com/opencontainers/runc/issues/1326 or https://github.com/moby/moby/issues/31230

jetstack-bot commented 6 years ago

@wallrj: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
navigator-e2e-v1-10 414be899c5f0112f5dc9ad71a489d0e377a9dee1 link /test e2e v1.10

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
munnerz commented 6 years ago

/lgtm /approve

jetstack-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)~~ [munnerz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment