search

jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

WIP: Add script to update example manifests #271

Open kragniz opened 6 years ago

kragniz commented 6 years ago

Fixes #260.

NONE
jetstack-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: We suggest the following additional approver: munnerz

Assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - **[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)** You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
kragniz commented 6 years ago

This currently only updates the cassandra example. The elasticsearch example a bit more different from the manifest used in e2e tests, so I haven't added it yet.

/cc @munnerz

jetstack-bot commented 6 years ago

@kragniz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
navigator-e2e-v1-7 bbb0b72cd37a6d0e854df26ddcca594e332d031d link /test e2e v1.7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
munnerz commented 6 years ago

We also need a corresponding verify script here.

FWIW, as I've said before, I do not think our e2e tests should only be driven by docs. Instead, we should have tests for the things in our docs (i.e. using sphinx's testing features), but the e2e test suite should test more advanced features which may or may not make sense to include in our documentation.

jetstack-bot commented 6 years ago

@kragniz: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.