Add shortName for cassandracluster

jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes

Apache License 2.0

271 stars 31 forks source link

Add shortName for cassandracluster #279

Closed kragniz closed 6 years ago

kragniz commented 6 years ago

So commands like kubectl get cass are shorter.

none

wallrj commented 6 years ago

I've got mixed feelings about this.

I'm not a fan of short names....I think they make shell scripts unclear, and kubectl command line completion takes away the pain of typing out the full name.
Perhaps I'd suggest kubectl get cassandra
But happy to go with this if others are in favour.
What ever we choose let's use both short and long forms in the E2E tests, so that we can see it working.
A simple kubectl get cass at the start of the test would be sufficient.

munnerz commented 6 years ago

kubectl get cassandra feels more natural and sets a precedent for how we shorten names in future (e.g. CouchbaseCluster -> couchbase) etc.

I'm not bothered about cass too much, but it does seems to be an arbitrarily shortened version of cassandra and isn't particularly obvious. wdyt @kragniz?

kragniz commented 6 years ago

cass was pretty random, I'm happy with cassandra instead.

munnerz commented 6 years ago

ping @kragniz

kragniz commented 6 years ago

Updated with cassandra and elasticsearch shortnames

jetstack-bot commented 6 years ago

@kragniz: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
navigator-e2e-v1-10	06319c63669dcb029f828cff3da392926cc2b774	link	`/test e2e v1.10`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

munnerz commented 6 years ago

/lgtm /approve

jetstack-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)~~ [munnerz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment