search

jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

Pilot init container resource limits #280

Closed cehoffman closed 6 years ago

cehoffman commented 6 years ago

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

Init containers to install the pilot into the database container should have resource limits specified too to operate inside of quota enforced namespaces.

wallrj commented 6 years ago

In https://github.com/wallrj/navigator/commit/bed5173f47aec3a50520b60afa374e87feb01236#r28074128 @cehoffman wrote:

This is only enforcing that requests are set. We have quota set to have caps on limits as well. https://kubernetes.io/docs/concepts/policy/resource-quotas/

Thanks Chris, so we need to add limits and requests on the Init container. Sorry I missed that. I was concentrating only on allowing configuration of main pod resources. I'll try and test and fix that tomorrow.

wallrj commented 6 years ago

/reopen

jetstack-bot commented 6 years ago

@wallrj: The reopen prow plugin is deprecated, please migrate to the lifecycle plugin before April 2018

In response to [this](https://github.com/jetstack/navigator/issues/280#issuecomment-372967796): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.