jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

Allow Cassandra NodePools to be configured with resource requests and limits. #282

Closed wallrj closed 6 years ago

wallrj commented 6 years ago

Fixes: #280

Release note:

NONE
wallrj commented 6 years ago

Added quotas to all the E2E test namespaces and now I see this warning in the events:

        {
            "name": "cass-test-ringnodes.151b7aba66078503",
            "namespace": "test-cassandra-1520944168-10788",
            "selfLink": "/api/v1/namespaces/test-cassandra-1520944168-10788/events/cass-test-ringnodes.151b7aba66078503",
            "uid": "571b5ac2-26ba-11e8-bd3d-5254002248c3",
            "resourceVersion": "3217",
            "creationTimestamp": "2018-03-13T12:30:40Z",
            "InvolvedObject": {
                "Kind": "StatefulSet",
                "Namespace": "test-cassandra-1520944168-10788",
                "Name": "cass-test-ringnodes",
                "UID": "5704c37f-26ba-11e8-bd3d-5254002248c3",
                "APIVersion": "apps",
                "ResourceVersion": "1114",
                "FieldPath": ""
            },
            "Reason": "FailedCreate",
            "Message": "create Pod cass-test-ringnodes-0 in StatefulSet cass-test-ringnodes failed error: pods \"cass-test-ringnodes-0\" is forbidden: failed quota: navigator-test-quota: must specify cpu,memory",
            "Source": {
                "Component": "statefulset",
                "Host": ""
            },
            "FirstTimestamp": "2018-03-13T12:30:40Z",
            "LastTimestamp": "2018-03-13T12:50:16Z",
            "Count": 55,
            "Type": "Warning"
        },

So let's try fixing that...

wallrj commented 6 years ago

/retest

munnerz commented 6 years ago

/lgtm /approve

jetstack-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - ~~[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)~~ [munnerz] You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
jetstack-ci-bot commented 6 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

jetstack-ci-bot commented 6 years ago

Automatic merge from submit-queue.