jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

Add limits as well requests to all Navigator pod containers. #284

Closed wallrj closed 6 years ago

wallrj commented 6 years ago

Fixes: #280

Release note:

NONE
wallrj commented 6 years ago

The events log shows this error:

        {
            "name": "nav-e2e-navigator-apiserver-68d95ddd9b.151bc3660dde7b48",
            "namespace": "navigator",
            "selfLink": "/api/v1/namespaces/navigator/events/nav-e2e-navigator-apiserver-68d95ddd9b.151bc3660dde7b48",
            "uid": "6071c90c-2774-11e8-96cb-5254009d0f4e",
            "resourceVersion": "912",
            "creationTimestamp": "2018-03-14T10:42:22Z",
            "InvolvedObject": {
                "Kind": "ReplicaSet",
                "Namespace": "navigator",
                "Name": "nav-e2e-navigator-apiserver-68d95ddd9b",
                "UID": "606c4e5b-2774-11e8-96cb-5254009d0f4e",
                "APIVersion": "extensions",
                "ResourceVersion": "814",
                "FieldPath": ""
            },
            "Reason": "FailedCreate",
            "Message": "Error creating: pods \"nav-e2e-navigator-apiserver-68d95ddd9b-\" is forbidden: failed quota: navigator-test-quota: must specify limits.cpu,limits.memory",
            "Source": {
                "Component": "replicaset-controller",
                "Host": ""
            },
            "FirstTimestamp": "2018-03-14T10:42:22Z",
            "LastTimestamp": "2018-03-14T10:43:03Z",
            "Count": 14,
            "Type": "Warning"
        },

So now I'll attempt to add limits to all the containers.

wallrj commented 6 years ago

Oops. I forgot the sysctl init containers.

wallrj commented 6 years ago

Doh! kubectl run --limits ... --requests ... is the way.

W0314 14:07:09.592] + kubectl run in-cluster-cmd-3094 --namespace=test-cassandra-1521035862-21054 --image=cassandra:latest --restart=Never --rm --stdin=true --attach=true --quiet --limits=request.cpu=100m,limit.cpu=100m,request.memory=500Mi,limit.memory=500Mi -- /usr/bin/cqlsh cass-test-nodes 9042
W0314 14:07:09.887] Error from server (Forbidden): pods "in-cluster-cmd-3094" is forbidden: failed quota: navigator-test-quota: [spec.containers[0].resources.limits[request.memory]: Invalid value: "request.memory": must be a standard resource type or fully qualified, spec.containers[0].resources.limits[request.memory]: Invalid value: "request.memory": must be a standard resource for containers, spec.containers[0].resources.limits[limit.cpu]: Invalid value: "limit.cpu": must be a standard resource type or fully qualified, spec.containers[0].resources.limits[limit.cpu]: Invalid value: "limit.cpu": must be a standard resource for containers, spec.containers[0].resources.limits[limit.memory]: Invalid value: "limit.memory": must be a standard resource type or fully qualified, spec.containers[0].resources.limits[limit.memory]: Invalid value: "limit.memory": must be a standard resource for containers, spec.containers[0].resources.limits[request.cpu]: Invalid value: "request.cpu": must be a standard resource type or fully qualified, spec.containers[0].resources.limits[request.cpu]: Invalid value: "request.cpu": must be a standard resource for containers, spec.containers[0].resources.requests[limit.memory]: Invalid value: "limit.memory": must be a standard resource type or fully qualified, spec.containers[0].resources.requests[limit.memory]: Invalid value: "limit.memory": must be a standard resource for containers, spec.containers[0].resources.requests[request.cpu]: Invalid value: "request.cpu": must be a standard resource type or fully qualified, spec.containers[0].resources.requests[request.cpu]: Invalid value: "request.cpu": must be a standard resource for containers, spec.containers[0].resources.requests[request.memory]: Invalid value: "request.memory": must be a standard resource type or fully qualified, spec.containers[0].resources.requests[request.memory]: Invalid value: "request.memory": must be a standard resource for containers, spec.containers[0].resources.requests[limit.cpu]: Invalid value: "limit.cpu": must be a standard resource type or fully qualified, spec.containers[0].resources.requests[limit.cpu]: Invalid value: "limit.cpu": must be a standard resource for containers]
jetstack-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kragniz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - ~~[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)~~ [kragniz] You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
jetstack-ci-bot commented 6 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

jetstack-ci-bot commented 6 years ago

Automatic merge from submit-queue.