search

jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

Add NamespaceLifecycle admission controller and enable admission #288

Closed munnerz closed 6 years ago

munnerz commented 6 years ago

What this PR does / why we need it:

Adds the NamespaceLifecycle admission controller, and enables admission control in the apiserver using a PluginInitializer that supports injecting both a kube & navigator clientset/informer factory.

Which issue this PR fixes: fixes #231

Special notes for your reviewer:

This needs an e2e test to ensure admission control is working properly by default

Release note:

Fix bug where Navigator resources could be created in namespaces that did not exist
jetstack-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kragniz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files: - ~~[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)~~ [kragniz] You can indicate your approval by writing `/approve` in a comment You can cancel your approval by writing `/approve cancel` in a comment
jetstack-ci-bot commented 6 years ago

/test all [submit-queue is verifying that this PR is safe to merge]

munnerz commented 6 years ago

/retest