jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

ParseNodePoolResourceName fails when node pool name contains a `-` #304

Closed munnerz closed 6 years ago

munnerz commented 6 years ago

I've just tried deploying a Cassandra cluster and with two nodepools: ringnodes-a and ringnodes-b. It is complaining:

statefulset name "cass-demo-ringnodes-a" did not contain cluster name "demo"

We shouldn't be relying on parsing the name of the statefulset in order to determine anything. We should use labels/annotations instead. This locks us to a particular naming format forever, and if ever we look at 'rolling' statefulsets (like how the Deployment controller does with ReplicaSets), this will become a bit of a nightmare to manage 😄

/kind bug /area cassandra