jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

Identify statefulsets by labels rather than error prone name parsing #309

Closed wallrj closed 6 years ago

wallrj commented 6 years ago

Fixes: #304

Release note:

NONE
wallrj commented 6 years ago

In the initial commit I used - in the nodepool names, recreating the original bug report. So these tests should all fail:

retest-bot commented 6 years ago

/retest This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack). Review the full test history for this PR. Silence the bot with an /lgtm cancel comment for consistent failures.

wallrj commented 6 years ago

/lgtm cancel

wallrj commented 6 years ago

/lgtm

jetstack-bot commented 6 years ago

@wallrj: you cannot LGTM your own PR.

In response to [this](https://github.com/jetstack/navigator/pull/309#issuecomment-379251354): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
munnerz commented 6 years ago

/lgtm

jetstack-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kragniz, munnerz, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)~~ [kragniz,munnerz,wallrj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
wallrj commented 6 years ago

/retest

kragniz commented 6 years ago

/retest