jetstack / navigator

Managed Database-as-a-Service (DBaaS) on Kubernetes
Apache License 2.0
271 stars 31 forks source link

Add GOFLAGS option to makefile #338

Closed kragniz closed 6 years ago

kragniz commented 6 years ago

By default this is set to "-a", but it allows you to unset it like:

make GOFLAGS="" build

to speed up builds.

none
munnerz commented 6 years ago

/lgtm /approve

On Wed, 18 Apr 2018 at 12:58, jetstack-bot notifications@github.com wrote:

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: munnerz

Assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here https://go.k8s.io/bot-commands.

The pull request process is described here https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jetstack/navigator/pull/338#issuecomment-382362050, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMbP_XnC5Ev4COyhaj8gzIeqZ4YvO9sks5tpypngaJpZM4TZ7lX .

jetstack-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)~~ [munnerz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment