Use local volumes instead of hostpath volumes

wallrj commented 6 years ago

Use local volumes rather than hostpath volumes in our e2e tests.
I need this for #347, where I'm bypassing the Docker image entrypoint script.
The entrypoint script would normally run chown to make cassandra user the owner of /var/lib/cassandra, and then exec su cassandra cassandra
But Kubernetes can take care of that using PodSecurityContext and SecurityContext RunAsUser and FSGroup.
Unfortunately, FSGroup doesn't work for HostPath volumes (https://github.com/kubernetes/kubernetes/pull/39438)
local volume provisioner does apply FSGroup when mounting the volume.
This change also allows e2e tests to pass on multi-node clusters, as described in #351
Although there's currently no way to enable PersistentLocalVolumes feature gate on kubeadm-dind clusters :-( (https://github.com/kubernetes-sigs/kubeadm-dind-cluster/issues/139)

Fixes: #351

Release note:

NONE

kragniz commented 6 years ago

/lgtm

kragniz commented 6 years ago

/approve

jetstack-bot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kragniz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jetstack/navigator/blob/master/OWNERS)~~ [kragniz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

jetstack / navigator

Use local volumes instead of hostpath volumes #366