jetstack / tarmak

A toolkit for Kubernetes cluster provisioning and lifecycle management
Apache License 2.0
269 stars 49 forks source link

Enforce single instance pool for all types except worker #320

Open dippynark opened 6 years ago

dippynark commented 6 years ago

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened: I can create multiple master/etcd/basition/vaul/jenkins instance pools in a single cluster. This doesn't make sense

What you expected to happen: Tarmak should error early (not just due to terraform templating) when creating multiple of the above instance pools

How to reproduce it (as minimally and precisely as possible): create multiple of any of the above instance pools

JoshVanL commented 6 years ago

/assign

simonswine commented 6 years ago

I would argue it makes sense to also allow multiple masters

dippynark commented 6 years ago

@simonswine what sort of use cases? Just having different sizes of master?