search

jetstack / tarmak

A toolkit for Kubernetes cluster provisioning and lifecycle management
Apache License 2.0
269 stars 49 forks source link

Make base AMI configurable #517

Open charlieegan3 opened 6 years ago

charlieegan3 commented 6 years ago

/kind feature

What happened: As a tarmak user with regulatory requirements, I may need to use an approved AMI across my infrastructure.

What you expected to happen: I would like to have the option to choose a base image when building tarmak images that is different from the tarmak default (https://aws.amazon.com/marketplace/pp/B00O7WM7QW).

Currently the image is hardcoded here: https://github.com/jetstack/tarmak/blob/master/packer/amazon/centos-puppet-agent.json#L15

charlieegan3 commented 6 years ago

Clearly a good feature to have in the open source. It does make the test-infra requirements more complicated if the new images were to be supported within this project.

simonswine commented 6 years ago

I think we can't really support that tarmak will run fine on custom images . I think we should specify requirements that those images need to meet, but in the end it's down to the image maintainer to verify them not breaking after updates of tarmak and/or the base images. I can't see a way of testing those as part of this project.

Further more custom images might come with operating systems and or settings that are not checked/set as part of tarmak and then preventing tarmak from run properly. (sysctl, selinux, firewall)

This will require also to use a different AMI id per region. So if we support that we need to get it specified by environment (as they are bound to one zone).