search

jetstack / tarmak

A toolkit for Kubernetes cluster provisioning and lifecycle management
Apache License 2.0
269 stars 49 forks source link

Increases vault max_lease_ttl to 5 years #801

Closed JoshVanL closed 5 years ago

JoshVanL commented 5 years ago

Signed-off-by: JoshVanL vleeuwenjoshua@gmail.com

/assign @simonswine 

Increase vault's max_lease_ttl to 5 years
jetstack-bot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[puppet/OWNERS](https://github.com/jetstack/tarmak/blob/master/puppet/OWNERS)~~ [JoshVanL] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
simonswine commented 5 years ago

/retest

simonswine commented 5 years ago

Why is this necessary? Is it not enough to do that using vault auth tune /token?

simonswine commented 5 years ago

/assign @JoshVanL /unassign

JoshVanL commented 5 years ago

@simonswine Yes should be /close

jetstack-bot commented 5 years ago

@JoshVanL: Closed this PR.

In response to [this](https://github.com/jetstack/tarmak/pull/801#issuecomment-488264765): >@simonswine Yes should be >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.