search

jetstack / tarmak

A toolkit for Kubernetes cluster provisioning and lifecycle management
Apache License 2.0
269 stars 49 forks source link

Add docs for socket path problem #817

Closed MattiasGees closed 5 years ago

MattiasGees commented 5 years ago

What this PR does / why we need it: Addresses problem with long temp paths for sockets.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

NONE
JoshVanL commented 5 years ago

Page looks good to me /approve /assign @simonswine

simonswine commented 5 years ago

/retest

simonswine commented 5 years ago

/retest

jetstack-bot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL, MattiasGees, simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[docs/OWNERS](https://github.com/jetstack/tarmak/blob/master/docs/OWNERS)~~ [JoshVanL,simonswine] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jetstack-bot commented 5 years ago

New changes are detected. LGTM label has been removed.

simonswine commented 5 years ago

/cherrypick release-0.6

jetstack-bot commented 5 years ago

@simonswine: new pull request created: #820

In response to [this](https://github.com/jetstack/tarmak/pull/817#issuecomment-504313442): >/cherrypick release-0.6 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.